perf: avoid unnecessary buffer copy in internalWrite #1013
Merged
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e03b871 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
See the code comments for details.
jasnell
force-pushed
the
jasnell/avoid-copy-buffers-in-internalwrite
branch
from
a428ff3 to
a7173ff
Compare
anonrig
approved these changes
Oct 11, 2025
vicb
changed the title
vicb
reviewed
Oct 11, 2025
vicb
previously requested changes
Oct 11, 2025
vicb
reviewed
Oct 11, 2025
vicb
reviewed
Oct 11, 2025
|
Thanks for the additional details @jasnell. IIUC the first change makes sense to avoid having to copy the buffer when it is already a buffer. Still not clear about
Can you measure any perf difference for that second change? |
vicb
dismissed
their stale review
'buffer' is a legit encoding value in _transform.
Does not seem to affect push and documented as not supported.
vicb
reviewed
Oct 15, 2025
vicb
reviewed
Oct 15, 2025
vicb
reviewed
Oct 15, 2025
vicb
reviewed
Oct 15, 2025
vicb
approved these changes
Oct 15, 2025
This was referenced Oct 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the code comments for details.
One challenge/question: it's not clear that this function is actually being tested with
pnpm run test... to check I added athrow new Error('boom')and ranpnpm run testand everything still passed./cc @vicb @anonrig